Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement the 'rollout' config option for percentage rollouts of sub-features #2880

Merged
merged 12 commits into from
Jan 8, 2025
Merged

Implement the 'rollout' config option for percentage rollouts of sub-features #2880

merged 12 commits into from
Jan 8, 2025

Conversation

sammacbeth
Copy link
Collaborator

Reviewer:

Description:

  • Adds support for the rollout sub-feature config option.
  • On-device dice roll when we see a new rollout. If this is within the rollout threshold, the sub-feature is marked as enabled. Otherwise it is disabled.
  • Includes unit-tests moved over from the Android test suite for the same feature.

Steps to test this PR:

Automated tests:

  • Unit tests
  • Integration tests
Reviewer Checklist:
  • Ensure the PR solves the problem
  • Review every line of code
  • Ensure the PR does no harm by testing the changes thoroughly
  • Get help if you're uncomfortable with any of the above!
  • Determine if there are any quick wins that improve the implementation
PR Author Checklist:
  • Get advice or leverage existing code
  • Agree on technical approach with reviewer (if the changes are nuanced)
  • Ensure that there is a testing strategy (and documented non-automated tests)
  • Ensure there is a documented monitoring strategy (if necessary)
  • Consider systems implications

@sammacbeth sammacbeth requested a review from kzar January 2, 2025 11:41
kzar
kzar approved these changes Jan 7, 2025
View reviewed changes
Copy link
Collaborator

@kzar kzar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes look good, I especially like how you split out the remote-config.js logic. I left a couple of comments with suggestions, but LGTM otherwise. (Also, it might be worth testing the devtools-panel.html page is still working if you didn't already?)

shared/js/background/background.js Outdated Show resolved Hide resolved
shared/js/background/components/remote-config.js Show resolved Hide resolved
@sammacbeth sammacbeth force-pushed the sam/abn branch 2 times, most recently from d4d6edf to b086643 Compare January 8, 2025 08:45
@sammacbeth sammacbeth merged commit 7860833 into main Jan 8, 2025
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kzar kzar kzar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sammacbeth @kzar